[java] Fix SpotBugs bugs in the Selenium manager (SeleniumHQ#14608)

Co-authored-by: Viet Nguyen Duc <[email protected]>
jkim2492 · Nov 17, 2024 · b3e366e · b3e366e
1 parent 7ec713e
commit b3e366e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/java/spotbugs-excludes.xml b/java/spotbugs-excludes.xml
@@ -230,4 +230,9 @@
     <Bug pattern="NM_CLASS_NAMING_CONVENTION"/>
   </Match>
 
+  <Match>
+    <Class name="org.openqa.selenium.manager.SeleniumManager"/>
+    <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
+  </Match>
+
 </FindBugsFilter>
diff --git a/java/src/org/openqa/selenium/manager/SeleniumManager.java b/java/src/org/openqa/selenium/manager/SeleniumManager.java
@@ -213,7 +213,7 @@ private synchronized Path getBinary() {
         if (!binary.toFile().exists()) {
           String binaryPathInJar = String.format("%s/%s%s", folder, SELENIUM_MANAGER, extension);
           try (InputStream inputStream = this.getClass().getResourceAsStream(binaryPathInJar)) {
-            binary.getParent().toFile().mkdirs();
+            Files.createDirectories(binary.getParent());
             Files.copy(inputStream, binary);
           }
         }

diff --git a/java/src/org/openqa/selenium/manager/SeleniumManagerOutput.java b/java/src/org/openqa/selenium/manager/SeleniumManagerOutput.java
@@ -98,6 +98,10 @@ private static Log fromJson(JsonInput input) {
           case "message":
             message = input.nextString();
             break;
+
+          default:
+            input.skipValue();
+            break;
         }
       }
       input.endObject();