Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a option to overrule the TLS REQUIRED option (reqcert) #12

Closed
wants to merge 2 commits into from
Closed

Implemented a option to overrule the TLS REQUIRED option (reqcert) #12

wants to merge 2 commits into from

Conversation

dstam
Copy link
Contributor

@dstam dstam commented Oct 21, 2015

This is the same pull-request as #11 but againts the changed master tree

@jirutka
Copy link
Owner

jirutka commented Oct 21, 2015

To be honest, I don’t want to support disabling TLS validation. It’s totally wrong approach, you should NEVER EVER do that! It’s like using password authentication without actually validating the password. If you have sef-signed certificate, then you can simply add it to your set of trusted certificates (typically /etc/ssl/certs).

@dstam
Copy link
Contributor Author

dstam commented Oct 22, 2015

I agree with you when using it in a production environment.

But when you are testing/developing (in my case) then you need the ability to disable it sometimes. In our environment (when I developing) I need to setup a ssh tunnel to our ldap environment. This means I connect to localhost. So even if your certificate is valid, the connection still fails due to localhost is not part of the certificate.

@jirutka
Copy link
Owner

jirutka commented Oct 25, 2015

Okay then, I’ve modified it a little and merged in 319e8be.

@jirutka jirutka closed this Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants