-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: further speedup for 2.0 startup #2510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/M
area/cli
This issue/PR affects the command line interface
area/core
This issue/PR affects the core codebase
area/daemon
area/entrypoint
This issue/PR affects the entrypoint codebase
area/helloworld
This issue/PR affects the helloworld
area/helper
This issue/PR affects the helper functionality
area/network
This issue/PR affects network functionality
area/testing
This issue/PR affects testing
component/client
component/docker
component/flow
component/jaml
component/logging
component/peapod
component/type
labels
May 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #2510 +/- ##
==========================================
- Coverage 83.29% 79.04% -4.25%
==========================================
Files 152 152
Lines 9444 9417 -27
==========================================
- Hits 7866 7444 -422
- Misses 1578 1973 +395
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jina-bot
added
size/L
area/docs
This issue/PR affects the docs
and removed
size/M
labels
May 30, 2021
jina-bot
added
area/housekeeping
This issue/PR is housekeeping
area/setup
This issue/PR affects setting up Jina
labels
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
This issue/PR affects the command line interface
area/core
This issue/PR affects the core codebase
area/docs
This issue/PR affects the docs
area/entrypoint
This issue/PR affects the entrypoint codebase
area/helloworld
This issue/PR affects the helloworld
area/helper
This issue/PR affects the helper functionality
area/housekeeping
This issue/PR is housekeeping
area/network
This issue/PR affects network functionality
area/setup
This issue/PR affects setting up Jina
area/testing
This issue/PR affects testing
component/client
component/docker
component/flow
component/jaml
component/logging
component/peapod
component/type
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0rc1 already achieves 2.2x speedup on startup and
from jina import Document, Executor, Flow
. This PR further improves the speed up by carefully inspectingand
This PR achieves 1.6x speedup on
import
(3.6x compare to1.x
):while
master
is at:This PR achieves 1.7x speedup on CLI
jina
(3.4x compare to1.x
)while
master
is at:Optimizations:
pkg_resources
(Importing pkg_resources is slow. Work is done at import time. pypa/setuptools#926, https://stackoverflow.com/a/9918496)