Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeout ready for executor docker images #854

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Nov 9, 2022

ViT-g/h and M-CLIP models usually take longer to download and have a high chance to timeout at the starting stage. This pr increases timeout_ready to 3000000ms

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #854 (bb0e6a5) into main (f96ce54) will increase coverage by 2.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   79.32%   81.39%   +2.06%     
==========================================
  Files          21       21              
  Lines        1596     1596              
==========================================
+ Hits         1266     1299      +33     
+ Misses        330      297      -33     
Flag Coverage Δ
cas 81.39% <ø> (+2.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/clip_trt.py 85.71% <0.00%> (+16.32%) ⬆️
server/clip_server/model/trt_utils.py 83.51% <0.00%> (+27.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 7108622 into main Nov 9, 2022
@numb3r3 numb3r3 deleted the fix-hub-docker branch November 9, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants