Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enable horizontal scrolling in wide tables #818

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Sep 9, 2022

This PR enables scrolling in wide tables like here https://clip-as-service.jina.ai/user-guides/server/#model-support

TBH, I don't know why this modification works 😅. I just don't see Jina core using sphinx_markdown_tables. The tutorials I found online are all about customizations in CSS. I guess sphinx_markdown_tables has some configurations that disable the scroll bar or set some fixed width.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

📝 Docs are deployed on https://ft-scroll-table--jina-docs.netlify.app 🎉

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #818 (626c887) into main (4461d2e) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files          21       21           
  Lines        1466     1466           
=======================================
  Hits         1230     1230           
  Misses        236      236           
Flag Coverage Δ
cas 83.90% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/clip_model.py 87.50% <0.00%> (ø)
server/clip_server/model/clip_onnx.py 82.22% <ø> (ø)
server/clip_server/model/clip_trt.py 85.71% <ø> (ø)
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZiniuYu ZiniuYu changed the title docs: enable horizontal scrolling in wide table docs: enable horizontal scrolling in wide tables Sep 9, 2022
@ZiniuYu ZiniuYu marked this pull request as ready for review September 9, 2022 06:41
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 47144c2 into main Sep 9, 2022
@numb3r3 numb3r3 deleted the scroll-table branch September 9, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants