Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace traversal_paths with access_paths #791

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Aug 1, 2022

This pr adapts the newest wording of parameter access_paths to improve narrative.

Similar to jina-ai/executor-text-dpr-encoder#7

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #791 (c3c82a4) into main (8b8082a) will decrease coverage by 2.77%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   84.30%   81.52%   -2.78%     
==========================================
  Files          21       21              
  Lines        1421     1440      +19     
==========================================
- Hits         1198     1174      -24     
- Misses        223      266      +43     
Flag Coverage Δ
cas 81.52% <65.51%> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_torch.py 82.53% <55.55%> (-5.18%) ⬇️
server/clip_server/executors/clip_tensorrt.py 92.72% <63.63%> (-7.28%) ⬇️
server/clip_server/executors/clip_onnx.py 84.05% <77.77%> (-1.66%) ⬇️
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

server/clip_server/executors/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_tensorrt.py Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu marked this pull request as ready for review August 2, 2022 10:19
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 3402b1d into main Aug 3, 2022
@numb3r3 numb3r3 deleted the access_path branch August 3, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants