feat: support onnx backend for openclip #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #781 +/- ##
==========================================
+ Coverage 85.72% 85.92% +0.20%
==========================================
Files 21 21
Lines 1121 1137 +16
==========================================
+ Hits 961 977 +16
Misses 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZiniuYu
reviewed
Jul 25, 2022
| elif self._model_name.endswith('-quickgelu'): | ||
| return self._model_name[:-10] | ||
| return self._model_name.replace('/', '-') | ||
| elif model_name.endswith('-quickgelu'): |
Comment on lines
+13
to
+19
| @staticmethod | ||
| def get_model_name(name: str): | ||
| return name | ||
|
|
||
| @property | ||
| def model_name(self): | ||
| return self.__class__.get_model_name(self._name) |
There was a problem hiding this comment.
To get the model name without initializing the instance (avoiding downloading and loading weights), we must use staticmethod . That's the reason I implement get_model_name
numb3r3
force-pushed
the
fix-onnx-openclip
branch
from
8b90a87 to
ddf86cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.