Use bookmarks created after the latest snapshot #625
Conversation
|
gentle bump |
|
would love to see this PR reviewed & merged @jimsalterjrs if time allows for it |
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
from
ab34d78 to
0232319
Compare
|
@jimsalterjrs @phreaker0 Ping |
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
3 times, most recently
from
d93bc7c to
ca7fb68
Compare
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
from
ca7fb68 to
3f6149a
Compare
|
@0xFelix sadly merge conflicts have creeped in again due to lots getting merged except this... I still rely on this PR in order to be able to use syncoid at all and would be willing to resolve the conflicts if I had write access to your repo. just let me know. |
|
@msladek Actually, I planned to pick up work on this and my other PR again soon, but help is always appreciated. Will contact you tomorrow. |
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
4 times, most recently
from
a47c12f to
f39f1a9
Compare
Before this sortsnapshots always tried to sort source snapshots, also when it was requested to sort target snapshots. This led to errors when the list of target and source snapshots was not identical. Fix it by allowing to specify an index when sorting snapshots.
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
from
f39f1a9 to
89b98ce
Compare
|
Rebased and working again. Ping @phreaker0 |
|
Also ping @jimsalterjrs |
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
from
89b98ce to
8e50a73
Compare
This commit changes syncoid's behavior so it is always looking for a matching snapshot and a matching bookmark. If the bookmark was created after the snapshot it is used instead. This allows replication when the latest snapshot replicated was deleted on the source, a common snapshot was found but rollback on the target is not allowed. The matching bookmark is used instead for replication. This fixes jimsalterjrs#602
0xFelix
force-pushed
the
bookmarks-after-latest-snapshot
branch
from
8e50a73 to
0266618
Compare
There was a problem hiding this comment.
this pr needs a rebase again, i just looked through and it looks good but I didn't test it.
I only have one concern, with this PR the bookmark list call is made for every dataset and may slow down the process for people which don't use the bookmark feature. Can you add a "no-bookmark" option to prevent the use of bookmarks?
This commit changes syncoid's behavior so it is always looking for
a matching snapshot and a matching bookmark. If the bookmark was created
after the snapshot it is used instead. This allows replication when the
latest snapshot replicated was deleted on the source, a common snapshot
was found but rollback on the target is not allowed. The matching bookmark
is used instead for replication.
This fixes #602