Add support for column separators in arrays (#127). #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add [ColumnSeparator] to EArray.
- Readers.MathML can generate any of {CSNone, CSDashed, CSSolid}, which should round-trip through Writers.MathML
- {Readers,Writers}.TeX only support {CSNone, CSSolid}
- Readers.OMML currently generates CSNone, and Writers.OMML doesn't emit ColumnSeparator information
… an off-by-1 in the TeX reader, and add the augmented matrix example to the test suite.
jgm
reviewed
Jan 10, 2021
| -- the contents of the lines. All of these lists should be | ||
| -- the same length. | ||
| -- the contents of the lines; the third gives the type of separator between | ||
| -- columns. The first two of these lists should be the same length, the last |
There was a problem hiding this comment.
This isn't quite right, is it? Rather, each ArrayLine should be the same length as the list of alignments.
There was a problem hiding this comment.
Conceptually, I'd prefer
EArray [Alignment] [ColumnSeparator] [ArrayLine]
with the content at the end and the "form" at the beginning.
|
Thanks - this looks good! I'd suggest changing the parameter order in EArray as noted. |
|
@aweinstock314 - did you plan to go forward with this? I think only a few changes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.