Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sarif convert #922

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Fix sarif convert #922

merged 5 commits into from
Sep 3, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Sep 3, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix: inserting the value of the converted result to the list before handling the specific scan changes

@attiasas attiasas added the ignore for release Automatically generated release notes label Sep 3, 2023
@attiasas attiasas changed the base branch from master to dev September 3, 2023 08:49
@attiasas attiasas requested a review from sverdlov93 September 3, 2023 08:50
@attiasas attiasas merged commit b9d14a8 into jfrog:dev Sep 3, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@attiasas