Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement quality lists for Locales #9983

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Implement quality lists for Locales #9983

merged 1 commit into from
Jun 28, 2023

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 28, 2023

Implement quality lists for Locales that orders known locales before unknown.

@gregw
Implement quality lists for Locales
dcad4e3 
Implement quality lists for Locales that orders known locales before unknown.
@gregw gregw requested review from joakime and lorban June 28, 2023 06:31
@gregw
Copy link
Contributor Author

gregw commented Jun 28, 2023

@lorban @joakime I spun this out of the NPE PR.

Now we produce a list of all Locales, but we order known ones before unknown.

lorban
lorban requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change can lead to an exploit.
Update: no, it cannot.

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Show resolved Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Show resolved Hide resolved
@gregw gregw merged commit daa7167 into jetty-12.0.x Jun 28, 2023
@gregw gregw deleted the jetty-12.0.x-locale-quality branch June 28, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregw @lorban