Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing JPMS and reactivating the tests #9911

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 15, 2023

Fix #9909 JPMS dependencies and reinstate JPMS tests.

@gregw
Copy link
Contributor Author

gregw commented Jun 15, 2023

@olamy Can you take this one over?
The issue appears to be that ee9-plus didn't have the required dependencies for jakarta-transactions (like ee10 does). I've copied them over and simple command line test like in the issue now work.
But when I re-enabled the demo distribution tests, I still have problems when JPMS is enabled.

Also, I'm not entirely sure what dependencies I should be using, as ee10 and ee9 use the same transactions API version, but appear to have different versions for it's dependencies. Not sure how to work out exactly which ones are needed? Also then there is ee8, which I've not yet looked at.

Finally, there are still version properties in the top level pom that are different yet again. Do we need them in the top level at all?

This test also revealed some other unrelated issues in the demos, so I will run down those rabbit holes if you can take this one over?

@gregw gregw requested a review from janbartel June 15, 2023 12:43
@olamy olamy changed the title WIP fixing JPMS and reactivating the tests fixing JPMS and reactivating the tests Jun 16, 2023
@olamy olamy marked this pull request as ready for review June 16, 2023 02:51
@olamy olamy merged commit 926a15a into jetty-12.0.x Jun 16, 2023
@olamy olamy deleted the jetty-12-9909-ee9-jpms branch June 16, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants