-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Cookie Cutter #9339
Merged
Merged
Review Cookie Cutter #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Bordet <[email protected]>
Trying to get a good code coverage. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
ignorable whitespace Signed-off-by: Greg Wilkins <[email protected]>
Select between CookieCutter and RFC6265CookieParser in factory method. Signed-off-by: gregw <[email protected]>
Select between CookieCutter and RFC6265CookieParser in factory method. Signed-off-by: gregw <[email protected]>
Select between CookieCutter and RFC6265CookieParser in factory method. Improved legacy modes Signed-off-by: gregw <[email protected]>
javadoc Signed-off-by: gregw <[email protected]>
Improve violation naming and javadoc Signed-off-by: gregw <[email protected]>
Updates and renames from review Signed-off-by: gregw <[email protected]>
Support new compliance violations in old CookieCutter parser Signed-off-by: gregw <[email protected]>
Exclude deprecated violations from non LEGACY modes. Signed-off-by: gregw <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
sbordet
commented
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
gregw
approved these changes
Feb 14, 2023
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this pull request
Feb 15, 2023
…old-docs-remove-logging-sections * origin/jetty-12.0.x: Fixed FormAuthenticator redirection Happy no year Restore range test for ee10 DefaultServletTest. Restore non cross-context async session tests Jetty 12 - Restore ee10 tests (jetty#9214) fixed commented out test in CookieCutterTest Fix/jetty 10 9334 review cookie cutter (jetty#9339) remove section on remote debugging, as the information has already been incorporated into the operations and programming guides remove sections on debugging with IntelliJ and Eclipse remove Ant Jetty plugin section from the ToC Remove docs for the ant plugin Update SECURITY.md (jetty#9333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.