Jetty 12.0.x ee10 convert cookie #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
reviewed
Dec 15, 2022
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java
Show resolved
Hide resolved
joakime
reviewed
Dec 15, 2022
...0/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletContextRequest.java
Outdated
Show resolved
Hide resolved
janbartel
added
the
TCK
…ee10-convert-cookie
…ee10-convert-cookie
…ee10-convert-cookie
joakime
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a number of ee10 cookie parsing issues, and also ensure
ServletContextRequest.getCookies()implements spec of returningnullfor no cookies rather than empty list.Fixes these tck tests:
com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie/URLClient.java.getDomainTest
com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie/URLClient.java.getPathTest
com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie/URLClient.java.setMaxAgeZeroTest
com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpservletrequest/URLClient.java.getCookiesNoCookiesTest
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie/URLClient.java.getDomainTest
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie/URLClient.java.getPathTest
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie/URLClient.java.setMaxAgeZeroTest
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/httpservletrequest/URLClient.java.getCookiesNoCookiesTest