-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for ambiguous URIs #12554
Conversation
documentation/jetty/modules/programming-guide/pages/server/compliance.adoc
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/compliance.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/compliance.adoc
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/compliance.adoc
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletHandler.java
Outdated
Show resolved
Hide resolved
updates from review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews not applied, but resolved?
Did you forget to push?
DOH! pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, but re-comment out the change to the output debug level to reduce test output.
jetty-ee10/jetty-ee10-servlet/src/test/resources/jetty-logging.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging config should be restored.
I prefer IO.rethrow()
, but I can live with ExceptionUtil.ifExceptionThrowAs()
.
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java
Show resolved
Hide resolved
updates from review
Fix #12162 by improving documentation on: