Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for ambiguous URIs #12554

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 20, 2024

Fix #12162 by improving documentation on:

  • ambiguous URI in servlet APIs
  • specifying properties in environments

@gregw gregw requested review from sbordet, janbartel and olamy November 20, 2024 23:19
olamy
olamy previously approved these changes Nov 21, 2024
@gregw gregw requested a review from sbordet November 26, 2024 00:58
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews not applied, but resolved?
Did you forget to push?

@gregw
Copy link
Contributor Author

gregw commented Nov 26, 2024

@gregw you resolved the comments, but there are no new commits? Did you forget to push?

DOH! pushed

@gregw gregw requested a review from sbordet November 26, 2024 22:16
janbartel
janbartel previously approved these changes Nov 27, 2024
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but re-comment out the change to the output debug level to reduce test output.

Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging config should be restored.

I prefer IO.rethrow(), but I can live with ExceptionUtil.ifExceptionThrowAs().

@gregw gregw merged commit 664d267 into jetty-12.0.x Nov 28, 2024
10 checks passed
@gregw gregw deleted the fix/12162/documentAmbiguousURIs branch November 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

"Ambiguous URI path encoding" when upgrading to Jetty 12 EE8
4 participants