Fix #10229 EE10 Idle Timeout #10233
Merged
Fix #10229 EE10 Idle Timeout #10233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to reproduce
Fixed NPE if no failure listener
|
@sbordet I think the issue here is that we created the |
|
Ah we do add a listener : |
|
hmmmm ServletRequestState: public boolean onIdleTimeout(TimeoutException timeout)
{
try (AutoLock ignored = lock())
{
if (LOG.isDebugEnabled())
LOG.debug("onIdleTimeout {}", getStatusStringLocked(), timeout);
// TODO this is almost always returning false?!? what about read/write timeouts???
// return _state == State.IDLE;
return true;
}
}yeah we didn't finish this! If I implement the TODO, the test passes! |
Possible fix
Added test that idle works between requests
EE9 idle timeout
idle if read operation
Handle idleTimeout for IO operations differently
improve comments
gregw
commented
Aug 5, 2023
Comment on lines
358
to
379
| Runnable invokeOnContentAvailable = _onContentAvailable; | ||
| _onContentAvailable = null; | ||
|
|
||
| // If a write call is in progress, take the writeCallback to fail below | ||
| Runnable invokeWriteFailure = _response.lockedFailWrite(t); | ||
|
|
||
| // If an IO operation was in progress | ||
| if (invokeOnContentAvailable != null || invokeWriteFailure != null) | ||
| { | ||
| // Then we will just fail the current operation and all future IO operation. | ||
| // No listeners are called at all, as the application is already notified | ||
| // TODO should we make this read failure transient, so it can be ignored by the application? | ||
| if (_failure == null) | ||
| { | ||
| _failure = Content.Chunk.from(t); | ||
| } | ||
| else if (ExceptionUtil.areNotAssociated(_failure.getFailure(), t) && _failure.getFailure().getClass() != t.getClass()) | ||
| { | ||
| _failure.getFailure().addSuppressed(t); | ||
| } | ||
|
|
||
| return _serializedInvoker.offer(invokeOnContentAvailable, invokeWriteFailure); |
There was a problem hiding this comment.
Much of this was copied over from onFailure, so if there is an IO operation in progress, we just fail them when an idle timeout occurs.
I think this needs careful review
fixed test to not expect timeout listener to be called if there is demand
Idle timeouts for IO operations are not last.
Disable transient idle timeouts since AsyncContentProducer cannot handle them.
revert test to persistent idle failures
sbordet
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10229