-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetty.sh
cannot handle complex Jetty properties from start.d/*.ini
#9309
Comments
Signed-off-by: Joakim Erdfelt <[email protected]>
I'm unable to replicate on the command line with Jetty 11.0.13. |
The error you are seeing is not from the format string, as the exception has something to do with resolving of an XML file. Can you run the following and give use the output?
Note: these should be different directories. |
Yes, I see it doesn't appear to be directly related to requestlog. However, I run into this issue, if try add this property to config. Here is This is without
|
Interesting filename ...
It should have no impact on your issue, just thought it was interesting to see. Can you check that you have access to the files listed in ...
Also check your The output of
Finally, try running with start.jar debug turned on, and see what the debug before the failure indicates?
The command line for |
Just found this issue arises only when I try run as a service. If run it directly ( Here is output from
|
Here is output for
I assume I forgot to change filename created by |
Your service is attempting to use Easiest option: If you can run without Next option: Take all of the properties defined after |
I am using default service script |
sigh. That script is a super sensitive file to maintain (seems every time we address something there we break someone's workflow). We have some niceties for I really don't want to get into the business of shell escaping those properties in --dry-run or within jetty.sh |
jetty.sh
cannot handle complex Jetty properties from start.d/*.ini
Should probably use |
Signed-off-by: Joakim Erdfelt <[email protected]>
Opened PR #9313 to make the escaping of command line arguments more comprehensive. Change is in branch @amjaliks I know you are using Jetty 11, and this PR is currently only in Jetty 10, but is there any way you can test it? (even if your environment starts, but fails to deploy the webapp, it's a great sign we are on the right path) |
I have an instance with Jetty 10 too. |
You can checkout the branch and build it ... $ git checkout fix/jetty-10.0.x/jetty-sh-start-properties
$ mvn clean install -DskipTests
# The as-built jetty-home can be found in jetty-home/target/jetty-home-10.0.14-SNAPSHOT.tar.gz |
No, this doesn't help. The same result, when trying to run as a service.
|
I'll keep working on the escaping side (it's needed for all things command line related, not just properties) I also need to introduce the |
…mat-with-spaces Issue #9309 - Introducing test for requestlog format with spaces
…x-documentation-operations-logging * upstream/jetty-12.0.x: (35 commits) Fixes jetty#9326 - Rename DecryptedEndPoint to SslEndPoint. Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) (jetty#9331) jetty#9328 - changes from review jetty#9287 - catch error in ee9 maxRequestSize MultiPart test Jetty 12.0.x 9301 fix ee10 jstl jpms (jetty#9321) Issue jetty#9301 Fix dependencies for ee10-glassfish-jstl module (jetty#9303) Jetty 12 Hazelcast 5.x and disable auto detection/multicast" (jetty#9332) jetty#9287 - fix further test failures Fixed imports. Issue jetty#7650 - Fix race condition when stopping QueuedThreadPool (jetty#9325) jetty#9287 - remove unpaired release of Content.Chunk Issue jetty#8991 - rename websocket isDemanding() method to isAutoDemanding() Issue jetty#9287 - fix failing tests changes f rom review add todo to revert to normal pool after fix for jetty#9311 Issue jetty#9309 - Introducing test for requestlog format with spaces use non-pooling RetainableByteBufferPool to work around performance bug consumeAvailable should use number of reads instead of bytes fix for retainable merge changes from review ...
…-properties Issue #9309 - Better jetty.sh integration for start.jar with eye on supporting odd properties
This fix has been merged into |
jetty.sh is broken, reopening. |
Closing, as new issues are covered in #9880 |
Jetty version(s)
Jetty 11.0.13
Java version/vendor
(use: java -version)
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment (build 17.0.5+8-Ubuntu-2ubuntu122.04)
OpenJDK 64-Bit Server VM (build 17.0.5+8-Ubuntu-2ubuntu122.04, mixed mode, sharing)
OS type/version
Distributor ID: Ubuntu
Description: Ubuntu 22.04 LTS
Release: 22.04
Codename: jammy
Description
Can't set custom request log format with spaces. Even example from comment.
If I add this line to requestlog.ini:
Jetty fails to run with error message (for a full stacktrace see below):
It is possible to add format without spaces and start Jetty successfully, for example:
Full stacktrace:
The text was updated successfully, but these errors were encountered: