Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment CookieConfig details not visible in Server Dump or JMX #12255

Closed
joakime opened this issue Sep 10, 2024 · 0 comments · Fixed by #12257
Closed

Environment CookieConfig details not visible in Server Dump or JMX #12255

joakime opened this issue Sep 10, 2024 · 0 comments · Fixed by #12257
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Sep 10, 2024

Jetty version(s)
12.0.13

Enhancement Description

The configured CookieConfig for an environment is not visible in dump or jmx.

When using jetty.server.dumpAfterStart=true to see the WebAppContext details for a Cookie Config, the output is simply ...

|        += oeje8w.WebAppContext@63eef88a{EE8 Demo Jetty WebApp,/ee8-test,file:///home/joakim/code/jetty/distros/bases/ee8-samesite-strict/webapps/ee8-demo-jetty/,true}{/home/joakim/code/jetty/distros/bases/ee8-samesite-strict/webapps/ee8-demo-jetty} - STARTED
|        |  +~ oeje8n.ContextHandler$CoreContextHandler@47dbb1e2{EE8 Demo Jetty WebApp,/ee8-test,b=file:///home/joakim/code/jetty/distros/bases/ee8-samesite-strict/webapps/ee8-demo-jetty/,a=AVAILABLE,h=GzipHandler@74cadd41{STARTED,min=2048,inflate=-1}} - STARTED
|        |  += oeje8n.SessionHandler@649725e3{STARTED} - STARTED
|        |  |  += oeje8n.SessionHandler$CoreSessionManager@3c0fae6c{STARTED} - STARTED
|        |  |  |  += org.eclipse.jetty.session.DefaultSessionCache@4c168660[evict=-1,removeUnloadable=false,saveOnCreate=false,saveOnInactiveEvict=false] - STARTED
|        |  |  |  |  += org.eclipse.jetty.session.NullSessionDataStore@52b56a3e[passivating=false,graceSec=3600] - STARTED
|        |  |  |  +~ oejs.DefaultSessionIdManager@3faf2e7d{STARTED}[worker=node0] - STARTED
|        |  |  |  +- ju.ImmutableCollections$ListN@1(size=0)
|        |  |  +- org.eclipse.jetty.ee8.nested.SessionHandler$CookieConfig@fd0e5b6
|        |  |  +- juc.CopyOnWriteArrayList@4eed470d(size=1)

Which shows no details about the configuration.
We should at least add a CookieConfig.toString() to make that entry useful.

The JMX level information for CookieConfig is also missing.

Screenshot from 2024-09-10 08-54-06

@joakime joakime changed the title Environment CookieConfig lacks toString for server dump Environment CookieConfig details not visible in Server Dump or JMX Sep 10, 2024
janbartel added a commit that referenced this issue Sep 11, 2024
joakime pushed a commit that referenced this issue Sep 18, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Jetty 12.0.14 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants