-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto add AliasChecker for custom Base Resource in DefaultServlet #11492
Labels
Comments
lachlan-roberts
added a commit
that referenced
this issue
Oct 1, 2024
…sourceServlet Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
added a commit
that referenced
this issue
Oct 21, 2024
…Checker Issue #11492 - Auto-add AliasChecker for custom Base Resource from ResourceServlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
Jetty 12.0.7
Enhancement Description
If a user adds a DefaultServlet with a custom Base Resource, like this ...
Then this base resource cannot serve content as the
AliasCheck
that come from the existingServletContextHandler
are not aware of this new Base Resource.Now a user will have to add an additional AliasCheck for this new Base Resource.
This is particularly difficult to do when using dynamic servlet registration techniques, or with the servlet descriptor (
WEB-INF/web.xml
)I propose that the
DefaultServlet
itself auto-add theAllowedResourceAliasChecker
for any custom Base Resource that it is told to use.The text was updated successfully, but these errors were encountered: