-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required php8.1 migrations #98
base: master
Are you sure you want to change the base?
Conversation
Any roadblocker against merging this branch? I am in the process of updating my server for namedmanager from Ubuntu 18.04 to 22.04. I'd like to continue using namedmanager (esp. as there are not that many alternatives...) but for this I need compatibility with PHP 8.1. Does this branch work on PHP 7.4? |
I use (a tiny customized variant of) this version with php8.1 in productive since a few weeks, without any problems |
I can confirm that (a) this branch seems to work flawlessly under PHP 8.1 as included in Ubuntu 22.04 and (b) that it also works under PHP 7.4 as included in Ubuntu 20.04. At least my brief tests showed no problems. It's a pity that the original project by jethrocarr seems to be stalled for some time now. E.g. the homepage website mentioned in the spec file has been moved to a domain advertising service. Incorporating this branch would make namedmanager fit again for the foreseeable future. And that would be a good thing as there are not so many alternatives. |
With these required changes (and tiny optional style improvements), namedmanager should be compatible with php7.x through php8.1.
No guarantee that all warnings / errors have been found and eliminated, but as a fast-fix for php8 support it should be fine :)