This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Protocol v11 #213
Merged
Protocol v11 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrnola
reviewed
Mar 13, 2018
| else | ||
| value ||| int64 (b <<< i) | ||
| let value = go 0L 0 | ||
| (value >>> 1) ^^^ -(value &&& 1L) |
There was a problem hiding this comment.
Ah okay I think I see what I did wrong now. Kafka was never "doubling" anything, it was just zigzag encoding a signed int64. Sorry about that!
|
Addresses: #179 |
This was referenced Mar 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the v11 protocol. More specifically, supports v5 of Fetch API and v3 of Produce API, both of which make use of the v2 message format (RecordBatch).