Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework sdk integration #98

Merged
merged 4 commits into from
Dec 28, 2018
Merged

rework sdk integration #98

merged 4 commits into from
Dec 28, 2018

Conversation

enricosada
Copy link
Contributor

  • remove unused props
  • allow multiple proto
  • generated .fs files, by default, are alongside the .proto files
  • use OutputPath metadata of ProtoFile item to specify generated .fs file path
  • compile files are included at beginning of the compile list (allow use in console app)
  • not yet implemented the clean process

add integration tests:

  • custom namespace
  • no generation on build if proto is unchanged
  • the .fs file is regenerated on build if proto file is changed

- remove unused props
- allow multiple proto
- generated .fs files, by default, are alongside the .proto files
- use `OutputPath` metadata of `ProtoFile` item to specify generated .fs file path
- compile files are included at beginning of the compile list (allow use in console app)
- not yet implemented the clean process

add integration tests:

- custom namespace
- no generation on build if proto is unchanged
- the .fs file is regenerated on build if proto file is changed
@enricosada enricosada merged commit 25e5591 into jet:master Dec 28, 2018
7sharp9 pushed a commit that referenced this pull request Jan 2, 2019
* rework sdk integration

- remove unused props
- allow multiple proto
- generated .fs files, by default, are alongside the .proto files
- use `OutputPath` metadata of `ProtoFile` item to specify generated .fs file path
- compile files are included at beginning of the compile list (allow use in console app)
- not yet implemented the clean process

add integration tests:

- custom namespace
- no generation on build if proto is unchanged
- the .fs file is regenerated on build if proto file is changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant