Fix time duration formatting as per SI #9765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getsnoopy
force-pushed
the
fix-time-formatting
branch
2 times, most recently
from
f5507db to
a6e5573
Compare
Codecov Report
@@ Coverage Diff @@
## master #9765 +/- ##
==========================================
+ Coverage 64.53% 64.56% +0.03%
==========================================
Files 290 291 +1
Lines 12321 12326 +5
Branches 3048 3048
==========================================
+ Hits 7951 7958 +7
+ Misses 3730 3729 -1
+ Partials 640 639 -1
Continue to review full report at Codecov.
|
getsnoopy
force-pushed
the
fix-time-formatting
branch
from
a6e5573 to
9ebabf5
Compare
This commit fixes the formatting of time durations to have a spcae between the quantity and the unit symbol which is compliant with the SI. It also consolidates all of the time duration formatting code into formatTime() in jest-util to keep the code DRY and so that future updates are easy.
getsnoopy
force-pushed
the
fix-time-formatting
branch
from
9ebabf5 to
3fbb08c
Compare
cpojer
approved these changes
May 2, 2020
jeysal
added a commit
to jeysal/jest
that referenced
this pull request
May 2, 2020
…hile-running * upstream/master: (331 commits) chore: update ts-eslint (jestjs#9953) Updated config docs with default transform value (jestjs#8583) Update jest-phabricator documentation (jestjs#8662) chore: remove dependency on `realpath-native` (jestjs#9952) chore: bump dated dependencies (jestjs#9951) chore: another try at fixing test-utils dependency chore: update lockfile due to beta release chore: move changelog entry and fix tets utils dependency Fix time duration formatting as per SI (jestjs#9765) v26.0.0-alpha.0 chore: run some jsdom tests in leak check (jestjs#9938) chore: upgrade chalk to v4 (jestjs#9752) feat: upgrade to JSDOM 16 (jestjs#9606) chore: remove checks for compileFunction (jestjs#9949) chore: drop node 8 support (jestjs#9423) Remove leftover `providesModuleNodeModules` (jestjs#9948) [BREAKING] Pojer -> Nakazawa chore: revert lockfile changes from 2b32fe6 chore: move changelog entry and fix lint Remove `providesModuleNodeModules` from Jest. (jestjs#9583) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the formatting of time durations to have a spcae
between the quantity and the unit symbol which is compliant with
the SI. It also consolidates all of the time duration formatting
code into formatTime() in jest-util to keep the code DRY and so
that future updates are easy.
Test plan
yarn jest formatTime