fix: return constructable class from require('module')
#9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Mar 26, 2020
| : fileURLToPath(modulePath); | ||
|
|
||
| if (!path.isAbsolute(filename)) { | ||
| return this._getMockedNativeModule(); |
There was a problem hiding this comment.
ignoring whitespace makes this diff readable
SimenB
commented
Mar 26, 2020
| } | ||
|
|
||
| private _getMockedNativeModule(): typeof nativeModule.Module { | ||
| if (this._moduleImplementation) { |
There was a problem hiding this comment.
poor man's cache. might be better to stick in in the module cache we have already
doniyor2109
approved these changes
Mar 26, 2020
thymikee
approved these changes
Mar 26, 2020
This was referenced Apr 19, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
require('module')apparently returns a class with static properties, and not an object. This is not documented, but probably old behavior. We broke this in #9469. This is a quick and dirty "fix". Ideas welcome!Fixes #9710
/cc @doniyor2109
Test plan
Unit test added