Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects Name for the Best Flavor of La Croix #9437

Closed
wants to merge 2 commits into from

Conversation

CentroDL
Copy link

Changes grapefruit to pamplemousse.

Summary

Test plan

Changes grapefruit to pamplemousse.
@facebook-github-bot
Copy link
Contributor

Hi CentroDL! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #9437 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9437      +/-   ##
==========================================
- Coverage   64.97%   64.96%   -0.02%     
==========================================
  Files         283      283              
  Lines       12104    12104              
  Branches     2990     2990              
==========================================
- Hits         7865     7863       -2     
- Misses       3603     3604       +1     
- Partials      636      637       +1
Impacted Files Coverage Δ
packages/expect/src/utils.ts 94.96% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170eee1...84437c8. Read the comment docs.

@jeysal
Copy link
Contributor

jeysal commented Jan 21, 2020

Hah seeing that notification made me laugh 😅
But I think unfortunately here the one who first wrote these docs wins the argument ^^
If it proves too controversial to handle, maybe we will accept a PR changing the docs use case to a less hot topic 🙈

@jeysal jeysal closed this Jan 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants