Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of custom abstraction on top of execa in e2e tests #8901

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 2, 2019

Summary

Removes the mapping of exitCode -> status. Also types the json field properly

Test plan

Green CI

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #8901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8901   +/-   ##
=======================================
  Coverage   64.24%   64.24%           
=======================================
  Files         275      275           
  Lines       11656    11656           
  Branches     2844     2843    -1     
=======================================
  Hits         7488     7488           
  Misses       3544     3544           
  Partials      624      624

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5545730...09898a3. Read the comment docs.

@SimenB SimenB merged commit c588c18 into jestjs:master Sep 2, 2019
@SimenB SimenB deleted the e2e-cleanup branch September 2, 2019 13:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants