-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for transforming runner #8854
Merged
+139
−2
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
803b706
feat: Allow transforming jest-runner
Mark1626 dd0181d
Replace test result with util
Mark1626 9fd4432
Fix linting
Mark1626 8c6af1b
Fix lint due to newline
Mark1626 9ba2a35
Add moduleFileExtensions in tests
Mark1626 bf97acc
Remove support for node 6
Mark1626 b6e1d5c
Add CHANGELOG
Mark1626 df745d2
chore: Move CHANGELOG entry and upgrade e2e dependency and missed items
Mark1626 61dab1f
chore: Review change
Mark1626 f1dc0a4
chore: Review change add import @jest/types as type
Mark1626 f546268
chore: Use file protocol to resolve dependency
Mark1626 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
it('should add two numbers', () => { | ||
expect(1 + 1).toBe(2); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
module.exports = { | ||
presets: [ | ||
['@babel/preset-env', {targets: {node: 'current'}}], | ||
'@babel/preset-typescript', | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"jest": { | ||
"rootDir": "./", | ||
"runner": "<rootDir>/runner.ts" | ||
}, | ||
"dependencies": { | ||
"@babel/preset-env": "^7.0.0", | ||
"@babel/preset-typescript": "^7.0.0", | ||
"jest-environment-node": "^26.6.2" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
import throat from 'throat'; | ||
import {TestResult, createEmptyTestResult} from '@jest/test-result'; | ||
import {Config} from '@jest/types'; | ||
Mark1626 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import { | ||
OnTestFailure, | ||
OnTestStart, | ||
OnTestSuccess, | ||
Test, | ||
TestRunnerContext, | ||
TestWatcher, | ||
} from 'jest-runner'; | ||
|
||
export default class BaseTestRunner { | ||
private _globalConfig: Config.GlobalConfig; | ||
private _context: TestRunnerContext; | ||
|
||
constructor(globalConfig: Config.GlobalConfig, context?: TestRunnerContext) { | ||
this._globalConfig = globalConfig; | ||
this._context = context || {}; | ||
} | ||
|
||
async runTests( | ||
tests: Array<Test>, | ||
watcher: TestWatcher, | ||
onStart: OnTestStart, | ||
onResult: OnTestSuccess, | ||
onFailure: OnTestFailure, | ||
): Promise<void> { | ||
const mutex = throat(1); | ||
return tests.reduce( | ||
(promise, test) => | ||
mutex(() => | ||
promise | ||
.then( | ||
async (): Promise<TestResult> => { | ||
await onStart(test); | ||
return { | ||
...createEmptyTestResult(), | ||
numPassingTests: 1, | ||
testFilePath: test.path, | ||
testResults: [ | ||
{ | ||
ancestorTitles: [], | ||
duration: 2, | ||
failureMessages: [], | ||
fullName: 'sample test', | ||
location: null, | ||
numPassingAsserts: 1, | ||
status: 'passed', | ||
title: 'sample test', | ||
}, | ||
], | ||
}; | ||
}, | ||
) | ||
.then(result => onResult(test, result)) | ||
.catch(err => onFailure(test, err)), | ||
), | ||
Promise.resolve(), | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"compilerOptions": { | ||
"esModuleInterop": true, | ||
"module": "commonjs", | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that work? to avoid hard-coding a version
do we even need these dependencies? I don't see
yarn
being run in hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check, the changes were made before yarn berry came in, with the
file:
protocol I'll see if it worksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works with the
file:
protocol in my local, updating in both here and thejest-env
PR