Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use babel-plugin-replace-ts-export-assignment package #8805

Merged
merged 1 commit into from
Aug 10, 2019
Merged

use babel-plugin-replace-ts-export-assignment package #8805

merged 1 commit into from
Aug 10, 2019

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 10, 2019

Summary

This replaces the babel-plugin-jest-replace-ts-export-assignment.js w/ a npm package version of the same script.

As requested by @SimenB 😄

Test plan

I wrote some tests for the package using jest, so I think that technically it's self-testing and that's cool.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 10, 2019

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

Pretty sure that's not caused by any of my changes 😬

@SimenB
Copy link
Member

SimenB commented Aug 10, 2019

Yeah, ignore the circus error

SimenB
SimenB approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit fafaf89 into jestjs:master Aug 10, 2019
@G-Rath G-Rath deleted the use-export-assignment-plugin branch August 11, 2019 09:12
jeysal added a commit to felipepastorelima/jest that referenced this pull request Aug 11, 2019
@jeysal
Merge remote-tracking branch 'upstream/master' into 8784
eb27a11 
* upstream/master:
  expect: Display equal values for ReturnedWith similar to CalledWith (jestjs#8791)
  Clearer messages for Node assert errors (jestjs#8792)
  use babel-plugin-replace-ts-export-assignment package (jestjs#8805)
  jest-matcher-utils: Add color options to matcherHint (jestjs#8795)
  chore: Make sure copyright header comment includes license (jestjs#8783)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-Rath @facebook-github-bot @SimenB