Concurrent reporter + Run failed tests first #1480

aaronabramov · 2016-08-23T23:27:55Z

codecov-io · 2016-08-25T18:26:43Z

Current coverage is 87.44% (diff: 100%)

Merging #1480 into master will not change coverage

@@             master      #1480   diff @@
==========================================
  Files            38         38          
  Lines          1211       1211          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1059       1059          
  Misses          152        152          
  Partials          0          0

Powered by Codecov. Last update 6546bcb...309f50f

aaronabramov · 2016-08-27T20:05:20Z

question.
right now this reporter tries to print when it's run on travis, and the output looks like this

is there a good way to detect if we run it inside a CI to avoid printing it?
process.stdin.isTTY does not really work.
should it be a module that can identify the most popular CI environment and return true/false?

maximderbin · 2016-08-27T23:25:13Z

@DmitriiAbramov on circle ci they has ENV var ENV['CIRCLECI'] travis should probably have something the same

aaronabramov · 2016-08-28T00:19:03Z

@maximderbin yeah... so i thought about making a package like jest-is-ci and having it return true if any of the env variables (like CIRLCECI, TRAVISCI) set. but i'm not sure if there's a better way to do it

alansouzati · 2016-08-29T21:14:44Z

packages/jest-cli/src/reporters/BaseReporter.js

-    for (let i = 0; i < string.length; i++) {
-      process.stderr.write(string.charAt(i));
-    }
+    process.stderr.write(string);


@DmitriiAbramov can you explain this? We had a huge issue in the past with previous node versions where on www the test run would just exit if there was a large amount of failures. You could potentially try this by failing 10 % of all assertions and running all tests on www. If the test run passes and prints big diffs, it is safe to remove it.

i tested it on www, but not by failing that many tests.
i believe this line should have fixed it. (process.on('exit')).
we should definitely test it more thoroughly though.

quantizor · 2016-08-30T04:26:14Z

NODE_ENV="CI"?

dirk · 2016-08-31T22:15:17Z

@DmitriiAbramov: Travis, Circle, and Buildkite all have CI=true in the environment. This is, I think, is the most reliable way to know when you're running on CI. 😉

aaronabramov · 2016-09-02T17:36:52Z

@dirk seems like that's exactly what we need! thanks! :)

aaronabramov · 2016-09-15T21:30:40Z

this also fixes the output in CI (except this 'running coverage' line, but that's not related to this change)

cpojer · 2016-09-21T08:51:30Z

packages/jest-cli/src/jest.js

 const getMaxWorkers = argv => {
  if (argv.runInBand) {
    return 1;
  } else if (argv.maxWorkers) {
-    return argv.maxWorkers;
+    return parseInt(argv.maxWorkers, 10);


hahaha. How long did it take you to figure out that you need to do this so that throat won't explode? Me, in the past when I did experiments, I had to sleep over it.

oh.. i actually thought it was an existing bug in jest :)

at least it didn't pass the flow types. i think it was number when specified in package.json and string if from CLI, or something like that

cpojer · 2016-09-23T09:08:20Z

Current Status:

* Concurrent reporter * Cleanup and Fixes * Add estimated runtime. * Run failed tests first. * Progress bar + printing cleanups. * Polish printing.

github-actions · 2021-05-13T13:13:59Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

ghost added the CLA Signed ✔️ label Aug 23, 2016

aaronabramov force-pushed the concurrent-reporter branch from 00e596b to 70cea3a Compare August 24, 2016 20:54

ghost added the CLA Signed ✔️ label Aug 24, 2016

ghost added the CLA Signed ✔️ label Aug 27, 2016

ghost added the CLA Signed ✔️ label Aug 28, 2016

alansouzati reviewed Aug 29, 2016
View reviewed changes

ghost added the CLA Signed ✔️ label Aug 31, 2016

ghost added the CLA Signed ✔️ label Sep 2, 2016

justingreenberg mentioned this pull request Sep 10, 2016

RFC: Update tests to use Jest/Enzyme react-boilerplate/react-boilerplate#970

Closed

cpojer added the Needs Revision label Sep 14, 2016

ghost added the CLA Signed ✔️ label Sep 14, 2016

cpojer removed the GH Review: needs-revision label Sep 14, 2016

ghost added the CLA Signed ✔️ label Sep 14, 2016

aaronabramov force-pushed the concurrent-reporter branch from 70cea3a to fdf0b64 Compare September 14, 2016 22:23

ghost added the CLA Signed ✔️ label Sep 14, 2016

aaronabramov force-pushed the concurrent-reporter branch from fdf0b64 to 1d4fcad Compare September 15, 2016 17:53

ghost added the CLA Signed ✔️ label Sep 15, 2016

cpojer reviewed Sep 21, 2016

View reviewed changes

ghost added the CLA Signed ✔️ label Sep 21, 2016

cpojer force-pushed the concurrent-reporter branch from 1d4fcad to 609da33 Compare September 23, 2016 02:10

ghost added the CLA Signed ✔️ label Sep 23, 2016

Concurrent reporter

f419b01

cpojer added 2 commits September 23, 2016 14:09

Cleanup and Fixes

9ca02ae

Add estimated runtime.

ed146ef

This was referenced Sep 23, 2016

Update estimated runtime based on real test time #1778

Closed

Failed tests should re-run first #1600

Closed

cpojer changed the title ~~Concurrent reporter~~ Concurrent reporter + Run failed tests first Sep 23, 2016

Run failed tests first.

835e750

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer force-pushed the concurrent-reporter branch from 082405a to 835e750 Compare September 23, 2016 06:17

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer force-pushed the concurrent-reporter branch from 864c3e9 to a811d5d Compare September 23, 2016 07:06

ghost added the CLA Signed ✔️ label Sep 23, 2016

Progress bar + printing cleanups.

07445b7

cpojer force-pushed the concurrent-reporter branch from a811d5d to 19c6a1c Compare September 23, 2016 07:53

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer force-pushed the concurrent-reporter branch from 19c6a1c to 6ccd878 Compare September 23, 2016 09:01

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer force-pushed the concurrent-reporter branch from 6ccd878 to f42ac48 Compare September 23, 2016 09:12

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer force-pushed the concurrent-reporter branch from f42ac48 to fad0e0e Compare September 23, 2016 09:31

Polish printing.

309f50f

cpojer force-pushed the concurrent-reporter branch from fad0e0e to 309f50f Compare September 23, 2016 09:34

ghost added the CLA Signed ✔️ label Sep 23, 2016

cpojer merged commit 428565b into jestjs:master Sep 23, 2016

mpj mentioned this pull request Nov 29, 2016

Configure Jest to bail on first error facebook/create-react-app#1108

Closed

aaronabramov deleted the concurrent-reporter branch June 8, 2017 18:01

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Concurrent reporter + Run failed tests first #1480

Concurrent reporter + Run failed tests first #1480

aaronabramov commented Aug 23, 2016

codecov-io commented Aug 25, 2016 •

edited

Loading

aaronabramov commented Aug 27, 2016

maximderbin commented Aug 27, 2016

aaronabramov commented Aug 28, 2016

alansouzati Aug 29, 2016

cpojer Sep 21, 2016

aaronabramov Sep 21, 2016

quantizor commented Aug 30, 2016

dirk commented Aug 31, 2016 •

edited

Loading

aaronabramov commented Sep 2, 2016 •

edited

Loading

aaronabramov commented Sep 15, 2016

cpojer Sep 21, 2016

aaronabramov Sep 21, 2016

aaronabramov Sep 21, 2016

cpojer commented Sep 23, 2016

github-actions bot commented May 13, 2021

Concurrent reporter + Run failed tests first #1480

Concurrent reporter + Run failed tests first #1480

Conversation

aaronabramov commented Aug 23, 2016

codecov-io commented Aug 25, 2016 • edited Loading

Current coverage is 87.44% (diff: 100%)

aaronabramov commented Aug 27, 2016

maximderbin commented Aug 27, 2016

aaronabramov commented Aug 28, 2016

alansouzati Aug 29, 2016

Choose a reason for hiding this comment

cpojer Sep 21, 2016

Choose a reason for hiding this comment

aaronabramov Sep 21, 2016

Choose a reason for hiding this comment

quantizor commented Aug 30, 2016

dirk commented Aug 31, 2016 • edited Loading

aaronabramov commented Sep 2, 2016 • edited Loading

aaronabramov commented Sep 15, 2016

cpojer Sep 21, 2016

Choose a reason for hiding this comment

aaronabramov Sep 21, 2016

Choose a reason for hiding this comment

aaronabramov Sep 21, 2016

Choose a reason for hiding this comment

cpojer commented Sep 23, 2016

github-actions bot commented May 13, 2021

codecov-io commented Aug 25, 2016 •

edited

Loading

dirk commented Aug 31, 2016 •

edited

Loading

aaronabramov commented Sep 2, 2016 •

edited

Loading