perf(jest-resolve): skip error creation on not found stat calls

[markjm]

Summary

Implements perf improvement for resolving discussed in #11738

Test plan

No user-facing changes requireing e2e testing. Added UT to ensure stacktrace is properly set back to pre-change value

[SimenB]

CI is very unhappy, would you be able to take a look 🙂

[markjm]

CI is very unhappy, would you be able to take a look 🙂

I will take another look shortly. The issue with CI is that the fix required for this change to work came in a patch version of node@16, so we would need to guard this optimization behind a capability check to meet the version support of jest.

[markjm]

Chose to use the new option as its even more performant and back-compat is easier. Blocked and waiting on this fix first though

isaacs/node-graceful-fs#220

cc @SimenB

[joux3]

Armed with a profiler I arrived at exactly the same optimisation (uvException/captureLargerStackTrace was on top of the profiler entries). For an actual test case real as measured by time for time node ./node_modules/.bin/jest --runInBand singletestxyz (which calls statSyncCached about 12k times) went from 4.0 seconds to about 3.8 seconds (best of 10 runs).

[SimenB]

@markjm graceful-fs seems to be patched now, so this is unblocked?

[markjm]

Wonderful - will fix up this PR by EOD!

[SimenB]

Great! A rebase, updating graceful-fs in package.jsons and a changelog entry would be great 👍

[codecov-commenter]

Codecov Report

Merging #11749 (061c040) into main (48f68a5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #11749      +/-   ##
==========================================
- Coverage   67.52%   67.51%   -0.01%     
==========================================
  Files         328      328              
  Lines       17246    17246              
  Branches     5071     5071              
==========================================
- Hits        11645    11644       -1     
- Misses       5568     5569       +1     
  Partials       33       33              

Impacted Files	Coverage Δ
packages/jest-resolve/src/fileWalkers.ts	67.79% <100.00%> (-1.70%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f68a5...061c040. Read the comment docs.

[markjm]

@SimenB cleaned up the commit and CI is passing. I see all circleCI passing, but its still waiting for approval for some workflow I cant seem to find.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.