Support default exports for runners #10826
Conversation
| @@ -193,7 +193,8 @@ export default class TestScheduler { | |||
| contexts.forEach(context => { | |||
| const {config} = context; | |||
| if (!testRunners[config.runner]) { | |||
| const Runner: typeof TestRunner = require(config.runner); | |||
| const Runner: typeof TestRunner = | |||
| require(config.runner).default || require(config.runner); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah ok cool. Later on I'll try to make use of this and add a changelog entry.
|
Actually, this will be covered by #8854 👍 Thanks for sending a PR tho 😀 |
|
@SimenB ok cool - but that PR hasn't been touched in over a year. So should we merge this instead? |
|
I believe that is only because of the breaking change. A rebase is probably all it needs to go into 27. Correct me if I'm wrong tho @SimenB |
|
yep, backed out of 26 to allow it to be non-breaking |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
When writing a new runner recently I noticed I couldn't use some TypeScript/bundler configurations because Jest was never looking for default exports. This is a small change which will allow for that.
Test plan
Tests pass locally apart from some irrelevant snapshot tests and hg tests.