fix: correct check for compatible find binary (#10346)

jestjs · Jul 31, 2020 · 2ab3fb2 · 2ab3fb2
1 parent 0708daf
commit 2ab3fb2
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Fixes
 
 - `[jest-cli]` Use correct file name to override existing jest config on init ([#10337](https://github.com/facebook/jest/pull/10337))
+- `[jest-haste-map]` Properly detect support for native `find` ([#10346](https://github.com/facebook/jest/pull/10346))
 
 ### Chore & Maintenance
 

diff --git a/packages/jest-haste-map/src/crawlers/__tests__/node.test.js b/packages/jest-haste-map/src/crawlers/__tests__/node.test.js
@@ -282,7 +282,11 @@ describe('node crawler', () => {
       rootDir,
       roots: ['/project/fruits'],
     }).then(({hasteMap, removedFiles}) => {
-      expect(childProcess.spawn).lastCalledWith('find', ['.', '-iname', "''"]);
+      expect(childProcess.spawn).lastCalledWith(
+        'find',
+        ['.', '-type', 'f', '(', '-iname', '*.ts', '-o', '-iname', '*.js', ')'],
+        {cwd: expect.any(String)},
+      );
       expect(hasteMap.files).toEqual(
         createMap({
           'fruits/directory/strawberry.js': ['', 33, 42, 0, '', null],

diff --git a/packages/jest-haste-map/src/crawlers/node.ts b/packages/jest-haste-map/src/crawlers/node.ts
@@ -30,9 +30,20 @@ async function hasNativeFindSupport(
 
   try {
     return await new Promise(resolve => {
-      // Check the find binary supports the non-POSIX -iname parameter.
-      const args = ['.', '-iname', "''"];
-      const child = spawn('find', args);
+      // Check the find binary supports the non-POSIX -iname parameter wrapped in parens.
+      const args = [
+        '.',
+        '-type',
+        'f',
+        '(',
+        '-iname',
+        '*.ts',
+        '-o',
+        '-iname',
+        '*.js',
+        ')',
+      ];
+      const child = spawn('find', args, {cwd: __dirname});
       child.on('error', () => {
         resolve(false);
       });