Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mode #1078

Merged
merged 17 commits into from
Oct 10, 2023
Merged

Run mode #1078

merged 17 commits into from
Oct 10, 2023

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Oct 9, 2023

This PR is mainly to implement the RunMode proposal #1058.

The goal is

  1. reduce confusion (runMode="off" has greatly been misunderstood).
  2. grouping UX-related settings to help improve discovery.
  3. introduce a new "deferred" mode to better support large projects and not-yet-ready projects.
  4. make the extension "less intrusive"

Additional changes (beyond #1058):

  • replaced TestExplorer's inline menu (autoRun, coverage) with a update-runMode button. Also integrated with testing framework's runProfile configuration mechanism.
  • replace the errorMessage pop-up with a less intrusive error notification mechanism: terminal error + quick-fix-chooser
  • added new command to save real-time runMode to settings.json, double up as a runMode migration command.
  • fix a few reveal output terminal bugs. It should be more true to "on-run" now.

Internal extension-development change:

  • clean up some staled/orphan files.
  • added coverage comparison script
  • add orphan image script to find and remove.

Reminder

We should move "autoClearTerminal" in here as well. But decided to leave it out for now since there is another outstanding work regarding Test Results tab. We can do the setting migration then.


resolve #1030
resolve #1025

@coveralls
Copy link

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6473103950

  • 503 of 503 (100.0%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 97.743%

Totals Coverage Status
Change from base Build 6201822640: -0.01%
Covered Lines: 3822
Relevant Lines: 3839

💛 - Coveralls

@connectdotz connectdotz merged commit 10414ab into jest-community:master Oct 10, 2023
13 checks passed
@connectdotz connectdotz deleted the runMode branch October 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance problems on large, multi-package monorepos Feature request: Introduce a power save mode
2 participants