Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes variable substitution in launch.json debug configurations when an
arg
contains more than one variableMore details in #1039
Previous
/Users/foo/bar/node_modules/.bin/sst bind 'jest --testNamePattern="${jest.testNamePattern}" --config jest.config.ts --runInBand --watchAll=false "/Users/foo/bar/path/test/createOrUpdateLineageIntegration.integration.test.ts"'
Now
/Users/foo/bar/node_modules/.bin/sst bind 'jest --testNamePattern="creating an integration returns 200" --config jest.config.ts --runInBand --watchAll=false "/Users/foo/bar/path/test/createOrUpdateLineageIntegration.integration.test.ts"'
Test
I added a unit test, verified it was failing without this change, and that it passes with this change.
I also followed the eat your own dog food steps in the CONTRIBUTING readme, and verified things work in our repository with this change + changing the settings.json
"jest.jestCommandLine"
value to"jest.jestCommandLine": "wrap () { NODE_OPTIONS=--experimental-vm-modules yarn sst bind \"jest --config=jest.config.ts $*\";}; wrap ",
to make sure the additional flags the plugin appends are substituted within
"jest ..."