-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearTerminal setting #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgillick Thanks for the PR, I think this is a useful feature. Sorry about the delayed response.
A few comments:
- let's change the setting to "autoClearTerminal".
- This probably only worked for the interactive runs, which is fine. But if we can find a way to make it also work for "watch" mode, that will be even better. The "watch" mode doesn't go through the "schedule" call as it is initiated outside of vscode. But it did emit other signals... see the
process-isteners
code for clues.
Thanks for the feedback.
|
Pull Request Test Coverage Report for Build 5381990409
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the update. The code's looking good, but we need to improve the test coverage for the new changes. After all, this is a test extension, right? We gotta walk the talk! 😄
When you get a chance, could you also update the Customization section in the README.md?
Apologies for the slow response on my end. This is a super useful change, and once those updates are made, I'll be ready to merge it in. Thanks again!
@connectdotz thanks for the feedback. I've added unit tests and updated the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Looks like there are some merge issues. Please see the comment.
BTW, you can yarn run ci
before check-in to ensure the tests and formats are correct before check-in.
src/JestExt/helper.ts
Outdated
@@ -111,6 +111,7 @@ export const getExtensionResourceSettings = ( | |||
|
|||
return { | |||
jestCommandLine: getSetting<string>('jestCommandLine'), | |||
autoClearTerminal: config.get<boolean>('autoClearTerminal') ?? false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use getSetting<boolean>
instead
Whoops, sorry about that. It should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that maybe a test is accidentally deleted?
Thanks for the PR! |
When auto-run is disabled, it's convenient to have the terminal clear and only show the results from the most recent run.
In this PR:
clearTerminal
boolean setting.clear()
toExtOutputTerminal
true
.