ci: don't run git hooks when in ci #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think skipping the install is better |
G-Rath
force-pushed
the
disable-husky-in-ci
branch
from
4e6d55e to
e15f1dc
Compare
|
Semantic release should skip hooks when they commit, but that's a different issue 😅 |
SimenB
reviewed
Mar 7, 2021
package.json
Outdated
| @@ -78,7 +78,8 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@typescript-eslint/experimental-utils": "^4.0.1" | |||
| "@typescript-eslint/experimental-utils": "^4.0.1", | |||
| "is-ci": "^3.0.0" | |||
There was a problem hiding this comment.
(pinst deals with it so it's not actually published as a postinstall)
There was a problem hiding this comment.
(it'd be nice if yarn v2 supported prepare 😞)
G-Rath
force-pushed
the
disable-husky-in-ci
branch
from
e15f1dc to
3ce2238
Compare
SimenB
approved these changes
Mar 7, 2021
|
🎉 This PR is included in version 24.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
Closed
Closed
This was referenced Mar 10, 2021
Closed
chore(deps-dev): bump eslint-plugin-jest from 24.1.3 to 24.2.0
Hashim-mansoor/react-music-player#131
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Husky now doesn't handle checking if you're in CI, so we have to ourselves.
This prevented #782 from going out.