Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests against eslint@7 #572

Merged
merged 1 commit into from
May 9, 2020
Merged

ci: run tests against eslint@7 #572

merged 1 commit into from
May 9, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 9, 2020

Closes #568
Closes #569

@G-Rath G-Rath merged commit 5e79476 into master May 9, 2020
@G-Rath G-Rath deleted the test-against-eslint-7 branch May 9, 2020 01:32
@SimenB
Copy link
Member

SimenB commented May 9, 2020

"eslint": "^5.1.0 || ^6.0.0",

?

@G-Rath
Copy link
Collaborator Author

G-Rath commented May 9, 2020

I was holding off updating the actual dependence until our other dependencies were updated, but happy to bump it if you don't mind the peer dependency warnings 🙂

@SimenB
Copy link
Member

SimenB commented May 9, 2020

Aha! I probably won't see the dependency warnings anyways 😀 But good call on holding off, those are annoying 👍

@SimenB
Copy link
Member

SimenB commented May 9, 2020

@G-Rath a thought, should we drop eslint 5 and increase minimum supported version to 6.7 and use the Suggestions API for out more dangerous autofixes? Such as toStrictEqual - that does change the semantic meaning, but especially no-test-callback as we've discussed previously.

Speaking of no-test-callback, we should probably rename it to no-done-callback and support hooks. This isn't the correct issue to discuss that I guess 😀

@G-Rath
Copy link
Collaborator Author

G-Rath commented May 9, 2020

I'm always keen to drop old versions - I was actually opening an issue to discuss these things halfway during the day but then did some house chores, applied a Windows update, etc

Lucky the powers of Chrome & Github have the issue body saved - I'll hit post and we can begin discussions :D

@github-actions
Copy link

🎉 This PR is included in version 23.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
2 participants