-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use export assignment #373
Conversation
@SimenB would you be able to recommend a good look to learn how to do mono-repos to make a PR for this into I've gotten the repo forked & setup locally, w/ all but two tests passing, but I've never worked w/ a mono-repo before, & jest is a big one 😬 I'm keen to make the PR myself, as I'm wanting to take a crack at 8330 after I've finished the TS conversation here (as a bit of a "break" before jumping into the open issues here). |
A monorepo isn't anything super special, and contributing.md should have the details on how to work with the code base. I don't know of any guides or blog posts, so I guess my googling would be as good as yours 🙂 Any particular questions?
If those are for mercurial ( |
Yeah, I've got it all setup & working, but the one thing contributing.md doesn't covert is adding new packages:
I saw that and decided to bail for now, in favor of reading up on how dependencies are handled in monorepos. So that's pretty much my main question: how do I add new dependencies?
They were, which is exactly why I ignored them 😄 I figured if they were really failing outside my environment, someone would already be handling it. |
Aha! Yeah, just do what the error suggests, add the |
Cheers, worked as expected - I'm now running the 8min+ test suite 😬 I'll carry on working on this stuff while pondering if I should have called it Just to complete my knowledge: Since packages don't have their own lock files, am I correct in thinking that adding a dep in a "package" works by the normal |
You must use |
🎉 This PR is included in version 22.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@SimenB I probably spent more time than I should, but hey least I know a lot more about babel :D
I'll make a PR into
jest
soon, once I've convinced my laptop to play nice (and once I've figured out how to install the package...).