Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update @commitlint to ^7.0.0 #311

Closed
wants to merge 1 commit into from
Closed

chore(package): update @commitlint to ^7.0.0 #311

wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jul 19, 2019

This resolves problems w/ committing on Windows, where the hooks would
fail due to $HUSKY_GIT_PARAMS issues.

@SimenB Apparently this is [a common thing]? Either way, w/ this the commit hooks now all work fine for me :)

Let me know if you want me to make another PR into the TS branch, or if you'll handle that.

This resolves problems w/ committing on Windows, where the hooks would
fail due to `$HUSKY_GIT_PARAMS` issues
@SimenB
Copy link
Member

SimenB commented Jul 19, 2019

The reason I haven't upgraded is that this requires node 8 and we support node 6. Could of course run yarn with --ignore-engines on CI. Would it work for you to only have this upgrade locally, but not push it? It only affect package.json and the lockfil, so you shouldn't need to juggle changes in a file for what to push and what not to

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jul 19, 2019

Ah yeah of course - didn't notice this with all the rushing around.

Would it work for you to only have this upgrade locally, but not push it?

The only problem is it's preventing me from merging my branch, since that reverts back to the original package.json, which has the deprecated usage of -e.

So far I'm doing everything on a single generic branch anyway, so it's not a big deal (then I can just cherry-pick commits out for PR later).

Sorry about that!

@SimenB
Copy link
Member

SimenB commented Jul 19, 2019

Happy to release a major dropping node 6 (it's eol after all). Just need to figure out which other changes we want to make at the same time

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 6, 2019

Node6 can't be dropped fast enough... 😭

@SimenB
Copy link
Member

SimenB commented Aug 6, 2019

I thought maybe to merge the TS rewrite, update the recommended rules, and make a major release

SimenB added a commit that referenced this pull request Oct 27, 2019
SimenB added a commit that referenced this pull request Oct 27, 2019
SimenB added a commit that referenced this pull request Oct 27, 2019
SimenB added a commit that referenced this pull request Oct 27, 2019
@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 27, 2019

Being done in next It'll be closed when that is merged.

@G-Rath G-Rath closed this Oct 27, 2019
@G-Rath G-Rath reopened this Oct 27, 2019
@G-Rath G-Rath closed this in b9213e0 Oct 27, 2019
@github-actions
Copy link

🎉 This issue has been resolved in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants