-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package): update @commitlint
to ^7.0.0
#311
Conversation
This resolves problems w/ committing on Windows, where the hooks would fail due to `$HUSKY_GIT_PARAMS` issues
The reason I haven't upgraded is that this requires node 8 and we support node 6. Could of course run |
Ah yeah of course - didn't notice this with all the rushing around.
The only problem is it's preventing me from merging my branch, since that reverts back to the original So far I'm doing everything on a single generic branch anyway, so it's not a big deal (then I can just cherry-pick commits out for PR later). Sorry about that! |
Happy to release a major dropping node 6 (it's eol after all). Just need to figure out which other changes we want to make at the same time |
Node6 can't be dropped fast enough... 😭 |
I thought maybe to merge the TS rewrite, update the recommended rules, and make a major release |
|
🎉 This issue has been resolved in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This resolves problems w/ committing on Windows, where the hooks would
fail due to
$HUSKY_GIT_PARAMS
issues.@SimenB Apparently this is [a common thing]? Either way, w/ this the commit hooks now all work fine for me :)
Let me know if you want me to make another PR into the TS branch, or if you'll handle that.