Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import webthing-iotjs to iotjs-modules #3

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Aug 1, 2019

Origin: https://github.com/rzr/webthing-iotjs
Bug: https://github.com/jerryscript-project/iotjs-modules/pull
Change-Id: I78cb57236f4cc828c2ed32b1f903dcc5ef7f62f7
IoT.js-Modules-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

Origin: https://github.com/rzr/webthing-iotjs
Bug: jerryscript-project#3
Change-Id: I78cb57236f4cc828c2ed32b1f903dcc5ef7f62f7
IoT.js-Modules-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
@rzr rzr force-pushed the sandbox/rzr/review/master branch from e0c55f5 to 5f47972 Compare August 1, 2019 07:39
Copy link

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzr
Copy link
Contributor Author

rzr commented Oct 11, 2019

Hi, can it be merged I will then add a couple of other modules to this repo.

cc: @haesik @akosthekiss

Copy link

@rtakacs rtakacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs rtakacs merged commit 381efee into jerryscript-project:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants