-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jenkins Pipeline compatibility #4
Conversation
6665fd9
to
8a5751a
Compare
Looks nice @EmteZogaf Will give it a try tonight, and if I can run an R script as before, and also within a pipeline, will merge and release :D Thanks! |
Actually, had to kill some time, so could test it right now 🎉 Used following script:
Success with normal freestyle job. Success with pipeline job too, using:
@EmteZogaf how do you feel about changing from rscript to r, the function name? |
OK, single-char commands look a bit strange to me. That's why I chose |
Indeed @EmteZogaf , but since the language, plug-in, and file extension are "r", that was the first thing I tried (though I could have used the helper screens to pre-populate scripts or found in the code what was the func name). Are you going to update the pull request, or should I merge and update it? |
Add compatibility with workflow/pipeline plugin. Copy behavior of ShellScript provided by workflow-durable-task-step-plugin for reusing the durability feature. The call to Rscript is wrapped in a shell script.
8a5751a
to
374e6fc
Compare
Updated |
Thanks @EmteZogaf ! Preparing a release now. |
Done. Announced in the biouno mailing list. Was also going to update a Wiki page, that I saw some time ago... I am quite sure there was a Wiki page with the list of plug-ins with pipeline compatibility, but alas I could not locate it. Thanks again @EmteZogaf |
Thanks for accepting the changes. |
That's the one that I had seen before. PR sent jenkinsci/pipeline-plugin#427 Thanks! |
FWIW I do not think this kind of step is a good idea. Better left to libraries or macros. But, see JENKINS-37011 & JENKINS-26055. |
These changes allow the usage of R plugin in pipeline scripts.
Re-submit of #1 because of accidental merge before review.