Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Netty transport #88

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Drop Netty transport #88

merged 1 commit into from
Nov 28, 2023

Conversation

basil
Copy link
Member

@basil basil commented Sep 28, 2023

The Netty-based transport adds significant weight to the JAR and complexity to the linker, and as of jenkinsci/docker-build-step-plugin#86 it won't be used anywhere except https://github.com/jenkinsci/nodepool-agents-plugin/blob/db1ddd9438516b676ef3accbd97df0ee1a875879/src/test/java/com/rackspace/jenkins_nodepool/NodePoolRule.java#L41 (which only has 40 installations).

@basil basil added the removed This PR removes a feature or a public API label Sep 28, 2023
@basil basil requested a review from a team as a code owner September 28, 2023 20:51
@basil
Copy link
Member Author

basil commented Oct 4, 2023

jenkinsci/docker-build-step-plugin#86 has been merged and released, so nothing is blocking the merge and release of this PR as far as I know.

@basil basil requested a review from ericcitaire October 4, 2023 16:47
@basil basil merged commit 9be0240 into jenkinsci:master Nov 28, 2023
15 checks passed
@basil basil deleted the netty branch November 28, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removed This PR removes a feature or a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant