Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Commons Compress library plugin #110

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ebarboni
Copy link
Contributor

Hi,

this pr is an attempt to fix https://issues.jenkins.io/browse/JENKINS-74985 as I also encounter this issue on my jenkins.
Looks like an aftermath of https://issues.jenkins.io/browse/JENKINS-73355
I have not idea on how to test this. Tests still passes after pr.

Basic concepts:
ignore all compress from docker-java, use commons-compress-api plugin to provide the api.
use a jenkins version + bom that manage version of commons-compress-api (I choose with not real conviction from sauce-ondemand as on on first result of usage of commons-compress-api plugin in all jenkins repo)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ebarboni ebarboni requested a review from a team as a code owner December 12, 2024 13:29
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 2.452.4 is a good choice because:

I'm using this incremental build in my environment without any issue.

@itfsw
Copy link

itfsw commented Dec 13, 2024

@ebarboni I'm the reporter of https://issues.jenkins.io/browse/JENKINS-74985, test this pr solved my problem, Thanks

@MarkEWaite
Copy link
Contributor

@ericcitaire or @ydubreuil could you label this pull request as "bug" and merge it? That will generate a new release and fix the issue for Jenkins users.

@basil basil added the bug Incorrect or flawed behavior label Dec 13, 2024
@basil basil changed the title use commons-compress-api as Jenkins core do not provide it anymore Use Commons Compress library plugin Dec 13, 2024
@basil basil merged commit 80b75fd into jenkinsci:master Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or flawed behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants