Modernize js #72
Closed
Modernize js #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been on my todo list for ages. Thanks!!! |
Within this scope `$` is `jQuery3`.
Variables declared by `let` are only available inside the block where they’re defined. Variables declared by `const` are like those declared by `let` but also cannot be mutated. `const` validation seems to fail with htmlunit. So everything is `let`. Variables declared by `var` are available throughout the function in which they’re declared. This change makes further refactoring easier.
kinow
approved these changes
Jun 19, 2023
|
Everything appears to be working fine! LGTM, thanks!
|
|
Squashed, merged, changelog added. Thanks @rahulsom ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is comprised of 4 individual commits that make use of a more modern javascript style.
jQuery3and$are one and the same. The code uses$so the code looks like typical jQuery code and IDEs recognize that the symbol is not undefined.varhas been replaced bylet. This reduces the scope of variables.All these changes should make further refactoring of code easier.
Testing done
This change only affects the UI and currently, the UI tests are not enabled.
I've used #71 to validate the behavior. Unfortunately, that cannot be merged.
I've also checked the behavior manually.
Submitter checklist