Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a compat test case which verifies that shallow clones can be deep… #1458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stspdotname
Copy link
Contributor

…ened

This test shows that deepening shallow clones works across all Git protocol versions. The trick to make this work is to pass depth=DEPTH_INFINITE

Related to issue #1399

@stspdotname stspdotname requested a review from jelmer as a code owner November 27, 2024 14:29
@jelmer
Copy link
Owner

jelmer commented Nov 27, 2024

Please rebase - the ruff issues are fixed in master.

@stspdotname
Copy link
Contributor Author

These commits are already based on 4de310b
which seems to be the latest at present?

@jelmer
Copy link
Owner

jelmer commented Nov 28, 2024

These commits are already based on 4de310b which seems to be the latest at present?

Whoops, the PR actually got stuck because of a spurious test failure. Current HEAD should be good.

…ened

This test shows that deepening shallow clones works across all Git protocol
versions. The trick to make this work is to pass depth=DEPTH_INFINITE

Related to issue jelmer#1399
@jelmer
Copy link
Owner

jelmer commented Nov 29, 2024

Changes LGTM, just needs a "ruff format" run?

@jelmer
Copy link
Owner

jelmer commented Nov 30, 2024

FWIW it looks like these test failures are repeatable, and appear in the newly added tests. They might be related to general brittleness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants