Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate various item rows to SDK #3643

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Migrate various item rows to SDK #3643

merged 7 commits into from
Jun 4, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Migrate "Specials" to SDK
  • Migrate "Additional parts" to SDK
  • Migrate "user views" to SDK
  • Migrate "Seasons" to SDK
  • Migrate "Upcoming episodes" to SDK
  • Migrate "More like this" to SDK
  • Migrate "Trailers" to SDK

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels Jun 4, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jun 4, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 4, 2024
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/browsing/BrowseRowDef.java
@@ -133,7 +133,7 @@
this.queryType = QueryType.LiveTvRecording;
}

public BrowseRowDef(String header, SimilarItemsQuery query, QueryType type) {
public BrowseRowDef(String header, GetSimilarItemsRequest query, QueryType type) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/browsing/BrowseRowDef.java
@@ -133,7 +133,7 @@
this.queryType = QueryType.LiveTvRecording;
}

public BrowseRowDef(String header, SimilarItemsQuery query, QueryType type) {
public BrowseRowDef(String header, GetSimilarItemsRequest query, QueryType type) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/browsing/BrowseRowDef.java
@@ -133,7 +133,7 @@
this.queryType = QueryType.LiveTvRecording;
}

public BrowseRowDef(String header, SimilarItemsQuery query, QueryType type) {
public BrowseRowDef(String header, GetSimilarItemsRequest query, QueryType type) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/browsing/BrowseRowDef.java
@@ -181,7 +181,7 @@

public GetLatestMediaRequest getLatestItemsQuery() { return latestItemsQuery; }

public SimilarItemsQuery getSimilarQuery() { return similarQuery; }
public GetSimilarItemsRequest getSimilarQuery() { return similarQuery; }

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
@@ -321,30 +320,27 @@
staticHeight = true;
}

public ItemRowAdapter(Context context, SimilarItemsQuery query, QueryType queryType, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetSimilarItemsRequest query, QueryType queryType, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
this.queryType = queryType;
}

public ItemRowAdapter(Context context, UpcomingEpisodesQuery query, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetUpcomingEpisodesRequest query, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
queryType = QueryType.Upcoming;
}

public ItemRowAdapter(Context context, SeasonQuery query, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetSeasonsRequest query, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
queryType = QueryType.Upcoming;
}

public ItemRowAdapter(Context context, SeasonQuery query, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetSeasonsRequest query, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
queryType = QueryType.Upcoming;
}

public ItemRowAdapter(Context context, SeasonQuery query, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetSeasonsRequest query, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
queryType = QueryType.Upcoming;
}

public ItemRowAdapter(Context context, SeasonQuery query, Presenter presenter, MutableObjectAdapter<Row> parent) {
public ItemRowAdapter(Context context, GetSeasonsRequest query, Presenter presenter, MutableObjectAdapter<Row> parent) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 0a9c8c8 into jellyfin:master Jun 4, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the sdk-itemrowadapter branch June 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero