Replace deprecated Request library with Axios #321
+30
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jbhannah, in case you're happy for a PR to resolve the security issues in the old deprecated Request library, you might like this solution.
I also bumped a number of other libraries that had security CVEs.
I had to drop the timeout error test as it just didn't play well with Axios despite trying very hard with a number of different methods (including alternatives to Nock) and even trying alternatives to Axios. Timeout testing seems difficult to get working well, and from what I can tell, the existing test wasn't perfect either.
Thanks for your open-source work!