Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Bump MyPy Python to 3.9 @ pre-commit config #2134

Merged
1 commit merged into from
Dec 16, 2024

Conversation

Mr-Sunglasses
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses commented Nov 3, 2024

The pre-commit.ci service dropped support for Python 3.8 as it's
gone EOL. This change makes the check runnable again. It is suboptimal
as we haven't yet dropped support for Python 3.8. #2144 will address
the underlying issue more thoroughly.

Resolves #2133.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@macro1 macro1 mentioned this pull request Dec 2, 2024
4 tasks
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the explanation of what is broken so it'd obvious if anything is actually being fixed or changed arbitrarily. Add an explanation of why it fixes the thing and why it was broken.

Also, we have to consider that this makes the runtimes inconsistent across the checks, and they should normally have the lowest supported runtime. If Python 3.8 support is being dropped, this should include dropping support from all the places, not just one.

@macro1
Copy link
Contributor

macro1 commented Dec 2, 2024

@webknjaz this is broken because the pre-commit GitHub Action no longer supports Python 3.8. it's not an issue with the project, it's a simple CI configuration adjustment

@webknjaz
Copy link
Member

webknjaz commented Dec 3, 2024

Wait, can you point out where GHA runs pre-commit? I thought we only got pre-commit.ci doing this...

@webknjaz webknjaz marked this pull request as draft December 4, 2024 03:16
@webknjaz
Copy link
Member

webknjaz commented Dec 4, 2024

I've converted this to draft to prevent accidental merging ahead of time.

@webknjaz webknjaz self-assigned this Dec 4, 2024
@webknjaz webknjaz added the skip-changelog Avoid listing in changelog label Dec 12, 2024
The `pre-commit.ci` service dropped support for Python 3.8 as it's
gone EOL. This change makes the check runnable again. It is suboptimal
as we haven't yet dropped support for Python 3.8. jazzband#2144 will address
the underlying issue more thoroughly.

Resolves jazzband#2133.

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
@webknjaz webknjaz changed the title fix: broken builds for pre-commit ci. 🧪 Bump MyPy Python to 3.9 @ pre-commit config Dec 12, 2024
@webknjaz webknjaz added tests Testing and related things maintenance Related to maintenance processes labels Dec 12, 2024
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a part of the combined CI fix. Please do not add any changes to this PR.

webknjaz added a commit to webknjaz/pip-tools that referenced this pull request Dec 12, 2024
webknjaz added a commit to webknjaz/pip-tools that referenced this pull request Dec 16, 2024
@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into jazzband:main in e604dec Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Related to maintenance processes skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken precommit ci builds.
3 participants