-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Bump MyPy Python to 3.9 @ pre-commit config #2134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the explanation of what is broken so it'd obvious if anything is actually being fixed or changed arbitrarily. Add an explanation of why it fixes the thing and why it was broken.
Also, we have to consider that this makes the runtimes inconsistent across the checks, and they should normally have the lowest supported runtime. If Python 3.8 support is being dropped, this should include dropping support from all the places, not just one.
@webknjaz this is broken because the pre-commit GitHub Action no longer supports Python 3.8. it's not an issue with the project, it's a simple CI configuration adjustment |
Wait, can you point out where GHA runs |
I've converted this to draft to prevent accidental merging ahead of time. |
The `pre-commit.ci` service dropped support for Python 3.8 as it's gone EOL. This change makes the check runnable again. It is suboptimal as we haven't yet dropped support for Python 3.8. jazzband#2144 will address the underlying issue more thoroughly. Resolves jazzband#2133. Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a part of the combined CI fix. Please do not add any changes to this PR.
e604dec
The
pre-commit.ci
service dropped support for Python 3.8 as it'sgone EOL. This change makes the check runnable again. It is suboptimal
as we haven't yet dropped support for Python 3.8. #2144 will address
the underlying issue more thoroughly.
Resolves #2133.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.