Add --no-strip-extras and warn about strip extras by default
#1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanhiebert check out #1955 where failures fixed. |
Use stdout as an output in test_compile_recursive_extras
atugushev
reviewed
Aug 6, 2023
atugushev
reviewed
Aug 7, 2023
atugushev
changed the title
--no-strip-extras and warn about strip extras by default
atugushev
added
enhancement
theryanwalker
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1613. In preparation for the next major release where
--strip-extraswill be the default, give a warning if the flag is not given and add a matching--no-strip-extrasflag to allow forcing the existing behavior without the warning.Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.I haven't written tests yet, because I'm not clear on the failures. I'm opening this PR for review and to see what the tests look like in the pull request.