Remove support for assigning None to a SplitField
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior wasn't documented and didn't fully work: it breaks as soon as you try to save a model with a `None` value.
|
With 73,057 Downloads last day* you are at least breaking someones code. But since it is undocumented and not working properly I'm not against it. |
|
Does that mean the PR is fine as it is or should I add a line to the ChangeLog? |
|
That is up to you, I don't have an opinion on this one. |
|
@gmcrocetti what is your opinion on this one? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior wasn't documented and didn't fully work: it breaks as soon as you try to save a model with a
Nonevalue.I think removing
Nonesupport is better than making it work:nullconstructor argument both in the implementation and in the type checking, which is a lot of worknull=Truefor text fields, so the value of the feature is questionableAs it was an undocumented feature that only partially worked, I think this change doesn't break backwards compatibility, so I didn't add it to the ChangeLog.